facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.18k stars 285 forks source link

sapling: fix threading cyclic import error when calling traceback #976

Closed ahornby closed 3 weeks ago

ahornby commented 3 weeks ago

Summary:

Test Plan:

Before:

./build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. sapling --num-jobs=32 --filter test-fb-ext-grpcheck.t --retry 0
...
-  You should be in devs group.
+  unknown python exception <class 'AttributeError'> Some(AttributeError("partially initialized module 'threading' has no attribute 'RLock' (most likely due to a circular import)")) (no-eol)
+  [1]

After:

----------------------------------------------------------------------
# Ran 1 tests, 0 skipped, 0 failed.
passed on try 0
facebook-github-bot commented 3 weeks ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.