Defer Gradle task creation until necessary

jrodbx commented 3 years ago

Closes #232

Screen Shot 2021-03-26 at 1 53 18 AM

facebook-github-bot commented 3 years ago

@xiphirx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 years ago

@xiphirx merged this pull request in facebook/screenshot-tests-for-android@010f36e6e51c5555cbfcd45067b8a5c79a4cb68d.

lwasyl commented 3 years ago

@jrodbx @xiphirx If I see correctly, this PR broke master:

There are couple of issues here:

configure accepts Action<T> so proper lambda should read it.init(...)
configure returns void, so to return whatever register gives us it'd have to be something like tasks.register(...).apply { configure { it.init(...) } }
createTask returns T : ScreenshotTask anyway, so even if lazy API is used to register the task, to return an instance of that task it would have to be immediately realized anyway

jrodbx commented 3 years ago

All great catches, thanks! I had relied on (and am now surprised by) the passing CI build.

facebook / screenshot-tests-for-android