search

facebook / squangle

SQuangLe is a C++ API for accessing MySQL servers
Other
123 stars 54 forks source link

Lack of makefile... #4

Closed fenrus75 closed 8 years ago

fenrus75 commented 9 years ago

There doesn't seem to be any sign of any makefile or related infrastructure....

fredemmott commented 9 years ago

This was released in an incomplete state so that it could be used by HHVM 3.6; it's fairly simple to build, and you can see how HHVM builds it here:

https://github.com/hhvm/hhvm-third-party/blob/master/squangle/CMakeLists.txt

The main thing you'd be likely to want to change is to not build a static library.

I'm trying to get this project owned as a standalone project instead of just a dependency, and this is definitely a priority once that happens.

fenrus75 commented 9 years ago

well yeah we're trying to package HHVM for our distro, and the released tarfile of it has no copy of squangle... hence wanting to package this one ;-)

On Tue, May 5, 2015 at 8:42 AM, Fred Emmott notifications@github.com wrote:

This was released in an incomplete state so that it could be used by HHVM 3.6; it's fairly simple to build, and you can see how HHVM builds it here:

https://github.com/hhvm/hhvm-third-party/blob/master/squangle/CMakeLists.txt

The main thing you'd be likely to want to change is to not build a static library.

I'm trying to get this project owned as a standalone project instead of just a dependency, and this is definitely a priority once that happens.

— Reply to this email directly or view it on GitHub https://github.com/facebook/squangle/issues/4#issuecomment-99120142.

fredemmott commented 9 years ago

We don't make tarballs - and unfortunately github's automatic ones don't include submodules :(

ghost commented 9 years ago

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

fredemmott commented 9 years ago

no thanks FBBot.

respu commented 9 years ago

Any updates on this ?

SharpMan commented 8 years ago

They won't they don't care. They are just saying 'Hi we have a mysql async client library !' especially when this quality of code https://github.com/facebook/squangle/blob/master/squangle/mysql_client/Query.cpp#L236 doesn't need to go in production

fredemmott commented 8 years ago

Closing all issues and moving to facebookarchive; this is still supported as a dependency of HHVM, but not as a standalone project.