starlark_bin: add --dialect option

facebook / starlark-rust

A Rust implementation of the Starlark language

Apache License 2.0

672 stars 53 forks source link

starlark_bin: add --dialect option #111

Closed dsheets closed 5 months ago

dsheets commented 5 months ago

I wanted to play with the variations between dialects you support and could not easily. This patch just creates a dialect option and enum and plumbs it through all the use sites in the executable.

At some future time, you or other project members may want finer grained control over the language extensions (or restrictions). I don't believe this change hinders that future effort therefore it seems to be low risk architecturally.

Thanks!

facebook-github-bot commented 5 months ago

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ndmitchell commented 5 months ago

Thanks for the PR - this looks reasonable to me!

facebook-github-bot commented 5 months ago

@ndmitchell merged this pull request in facebookexperimental/starlark-rust@c3033f35204f3271c4692293a526379e22f677e1.