facebook / starlark-rust

A Rust implementation of the Starlark language
Apache License 2.0
699 stars 57 forks source link

Removing autocomplete triggers breaks autocomplete #112

Closed cameron-martin closed 7 months ago

cameron-martin commented 7 months ago

4be1b3bbf38dbddfca9aabacbff82a644681ae9d removes some autocomplete triggers. However, this breaks autocomplete for labels in vscode.

Before this commit, I could hit ctrl+space in a string and get autocomplete suggestions from the language server:

image

However, after this change I only get the default vscode autocomplete:

image

cameron-martin commented 7 months ago

I believe the issue here is we're now sending None as completion_provider, which tells the client that the server does not support autocomplete. Instead it should be something like Some(CompletionOptions::default()).