search

facebook / starlark-rust

A Rust implementation of the Starlark language
Apache License 2.0
699 stars 57 forks source link

Re-enable completions #113

Closed cameron-martin closed 7 months ago

cameron-martin commented 7 months ago

4be1b3bbf38dbddfca9aabacbff82a644681ae9d disabled autocomplete by passing no completion provider to the client. However, I think the intention was to just remove the triggers, not disable all autocomplete. This re-enables this functionality.

Fixes #112

facebook-github-bot commented 7 months ago

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ndmitchell commented 7 months ago

Oops. Thanks for the fix.

facebook-github-bot commented 7 months ago

@ndmitchell merged this pull request in facebookexperimental/starlark-rust@581baa88e0d58740705a28730f036a4beb3a0ef2.