Parameter autocomplete improvements

facebook / starlark-rust

A Rust implementation of the Starlark language

Apache License 2.0

673 stars 53 forks source link

Closed MaartenStaa closed 11 months ago

MaartenStaa commented 11 months ago

Some autocomplete improvements aimed at typing parameters:

Correctly offer parameter completion options when typing a new parameter after the first one.
Omit already used parameter names as options.
Re-offer completion when typing a space after a comma in a function call (and other such cases).

ndmitchell commented 11 months ago

All looks good - importing with the intention of merging as is. I'll make the single line comment addition

facebook-github-bot commented 11 months ago

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 11 months ago

@ndmitchell merged this pull request in facebookexperimental/starlark-rust@c86e26b01bb822be6135c7d46d8af27c9097601b.