facebook / stetho

Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.
http://facebook.github.io/stetho/
MIT License
12.67k stars 1.13k forks source link

SQLite console broken in Chrome 72 #634

Open technoir42 opened 5 years ago

technoir42 commented 5 years ago

Stetho 1.5.0, Chrome 72.x

  1. Click on SQLite database
  2. Type: > SELECT 1<Enter>
  3. Nothing happens

There are no suspicious warnings in Logcat.

colemcallister commented 5 years ago

I am having the same issue.

ghost commented 5 years ago

I am working around this by using Chromium.

Following the instructions here, I believe 599028 was the last build before Chrome 71 was released, so I'm using that.

bluetoothfx commented 5 years ago

Yes I have also faced same issue & @ngriffiths solution works. But I think stetho dev should consider this. I have download this version of chromium and stetho works fine. For windows: Link: Version 71.0.3578.0 (Developer Build) (64-bit)

francescomapelli commented 5 years ago

the workaround to use an older chromium works. this build works on linux 64. taken from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/599034/

shibin-bb commented 5 years ago

@ngriffiths solution works fine. Thanks :+1:

androideveloper commented 5 years ago

The same here!

cerberusv2px commented 5 years ago

Same Here.

nawinkhatiwada commented 5 years ago

Same here

southerton81 commented 5 years ago

Same here - Ubuntu 16, Chrome Version 72.0.3626.81 (Official Build) (64-bit)

RumiRajbhandari commented 5 years ago

Facing the same issue.

yizems commented 5 years ago

same

ShaznaM commented 5 years ago

Not working for me either.

jubincn commented 5 years ago

Same here, macOS 10.14.3, chrome 72.0.3626.109

musooff commented 5 years ago

For those who are looking for older versions of Chrome https://www.slimjet.com/chrome/google-chrome-old-version.php It is working with 71.x (Tested on Mac)

longinoa commented 5 years ago

Hey @paulirish - not sure if you are still working on dev tools or not. But it seems like Chrome 72 has a regression when it comes to text entry. It is no longer able to execute any commands in various console boxes.

sathishmscict commented 5 years ago

Yes I have also faced same issue & @ngriffiths solution works. But I think stetho dev should consider this. I have download this version of chromium and stetho works fine. For windows: Link: Version 71.0.3578.0 (Developer Build) (64-bit)

Thank you

loeschg commented 5 years ago

I tried the Chrome canary channel and still have the same issue fwiw.

Version 74.0.3724.0 (Official Build) canary (64-bit)

jeremybras commented 5 years ago

Worked in chromium until yesterday 😢

bmilovanovic commented 5 years ago

When is this going to be fixed? We're seriously hurt with this.

phicdy commented 5 years ago

It looks to be fixed in Chrome 73.0.3683.75 (Official Build) (64bit)

technoir42 commented 5 years ago

Cannot confirm, still broken in Version 73.0.3683.75 (Official Build) (64-bit) on macOS.

davidbilik commented 5 years ago

It did not work for me on a first try on macOS either, but then I tried later and it worked 🤷‍♂️

bluetoothfx commented 5 years ago

Working fine on Version 73.0.3683.75 (Official Build) (64-bit) (windows)

tuliohmendes commented 5 years ago

Working fine on Version 73.0.3683.75 (Official Build) (64-bit) (macOS)

jonrysimbolon commented 5 years ago

For those who are looking for older versions of Chrome https://www.slimjet.com/chrome/google-chrome-old-version.php It is working with 71.x (Tested on Mac)

thank you

pakerwreah commented 5 years ago

Still does not work in DevTools on Version 73.0.3683.75 (Build officiel) (64 bits)

jasta commented 5 years ago

@paulirish is this something that upstream is fixing independently or does Stetho need to make changes to continue to operate? I know we're using an absolutely ancient version of the devtools but upgrading is prohibitively difficult at this point given how many non-backwards compatible features have been added since (even websocket compression alone would break us right out of the gate).

ilyamuromets commented 5 years ago

Ubuntu 18.04.2 LTS Google Chrome Version 73.0.3683.75 (Official Build) (64-bit)

Still does not work!

androideveloper commented 5 years ago

Win 10 Chrome Version 73.0.3683.86 (Official Build) (64-bit)

Still not working

charleston10 commented 5 years ago

Yes I have also faced same issue & @ngriffiths solution works. But I think stetho dev should consider this. I have download this version of chromium and stetho works fine. For windows: Link: Version 71.0.3578.0 (Developer Build) (64-bit)

Thanks. Work fine for me

Tolriq commented 5 years ago

Small reminder as I see way too much people downgrading to 71.x :)

Chrome version before 72.0.3626.12 have a MAJOR security issue (See CVE-2019-5786) Do not use those version to browse the web.

paulirish commented 5 years ago

@jasta so yes i'm pretty sure the shadow DOM/custom elements v0 removal broke you.

you have a few options

  1. try to get these APIs turned back on for your specific application. there's an origin trial to undo the removal: https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 I don't know what origin the devtools in stetho runs under. What does new URL(location.href).origin evaluate to?
  2. upgrade to the latest devtools frontend. it looks like you have a 4yr old frontend. You could try upgrading. the DOM/network/sql parts of the protocol havent really changed, so there's a good chance things work. But it's hard to say.
  3. polyfill the v0 APIs. We have basic polyfills for this written here. These solve the problem for us in the current frontend; though I'm not sure it'd work fine against your older version. Worth a shot tho.. this just has to be run in the page before the frontend is loaded.
federicoalvarez-github commented 5 years ago

Windows 10 Chrome Version 73.0.3683.86 (Official Build) (64-bit) Stetho 1.5.1

Still not working.

nkraev commented 5 years ago

Mac OS 10.14.3 Version 75.0.3745.4 (Official Build) dev (64-bit) - not working.

75th version, but still nothing 😞

jcardama commented 5 years ago

Windows 10 Version 75.0.3749.0 (Official Build) canary (64-bit) (cohort: Clang-64) - not working.

Hoping for a fix soon.

nerkoturkovic commented 5 years ago

I'm using Version 74.0.3729.131 (Official Build) (64-bit) (macOS) and still not working. I'm using Stetho 1.5.1 for Android

ubaierbhat commented 5 years ago

Reported to chromium team https://bugs.chromium.org/p/chromium/issues/detail?id=965418

AnkitPatanaik commented 5 years ago

@ubaierbhat looks like the Chromium team is not going to fix, what actions will the Stetho team take given this?

ilyamuromets commented 5 years ago

Chromium team was comment the problem:

Status: WontFix (was: Unconfirmed) Stetho is not something we support. You can file an issue on their github.

nkraev commented 5 years ago

Facebook is heavily investing into Flipper right now, and they abandoned Stetho. I think this can be closed as "won't fix" 🤔

ilyamuromets commented 5 years ago

Flipper built for debug iOS apps.

From Flipper's doc:

... And Stetho will continue to work and we are not abandoning it ...

technoir42 commented 5 years ago

Flipper team seems to be actively working on a database plugin https://github.com/facebook/flipper/pull/441.

Is there anything else blocking you from migrating to Flipper besides the lack of a database plugin?

angusholder commented 5 years ago

Looks like Flipper's desktop app is Mac-only, that's a big problem

On Mon, 27 May 2019, 10:53 Sergey Chelombitko, notifications@github.com wrote:

Flipper team seems to be actively working on a database plugin facebook/flipper#441 https://github.com/facebook/flipper/pull/441.

Is there anything else blocking you from migrating to Flipper besides the lack of database plugin?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebook/stetho/issues/634?email_source=notifications&email_token=ABYQN4PEVRGTAIBGNB4E74DPXOVQ5A5CNFSM4GUQI4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJLPUY#issuecomment-496154579, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYQN4PTMT37RKO5U4Q5VLTPXOVQ5ANCNFSM4GUQI4SQ .

ilyamuromets commented 5 years ago

@technoir42 we use Stetho for executing js code in the Chrome Console on Android app (not a react native app). Is it possible to do that with Flipper? And, of course, we develop Android app on Ubuntu.

technoir42 commented 5 years ago

Looks like Flipper's desktop app is Mac-only, that's a big problem

It's true that only macOS binaries are provided but the app itself is cross-platform. You can build it from source on Windows and Linux. I can confirm that it works on Windows although I had to install openssl separately.

ubaierbhat commented 5 years ago

This problem does not appear when stetho-sample is build and run locally. @technoir42 can you try cloning this repo and running stetho-sample.

AnkitPatanaik commented 5 years ago

@technoir42, Flipper looks pretty good! Do you know when we can expect that DB plugin to be released to the public?

domingos-panta commented 5 years ago

@ngriffiths solution works just fine. Thank you very much!!!

pakerwreah commented 5 years ago

I'm using the Canary build of Microsoft Edge based on Chromium and it works. The only caveat is that you can't use arrow-up to repeat a query, it doesn't work.

HugoMatilla commented 5 years ago

Microsoft Edge MacOS Version 76.0.176.1 Dev (64-bit), works for me.