search

facebook / stylex

StyleX is the styling system for ambitious user interfaces.
https://stylexjs.com
MIT License
8.22k stars 303 forks source link

Fixing NextJS installation instructions #499

Closed jherr closed 1 week ago

jherr commented 3 months ago

What changed / motivation ?

NextJS changed their configuration file to ESM, so a different file was needed. And the other changes were required to make it work. The original configuration didn't work. TBH, this needs to be reviewed by someone who understands the installation. This version works, but it's not clear if it's the correct fix.

Pre-flight checklist

facebook-github-bot commented 3 months ago

Hi @jherr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 3 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

nmn commented 3 months ago

Thanks @jherr. The prescripts are indeed very important. Our example Next apps have it, but we did fail to document that properly.

derekjwilliams commented 3 months ago

So good to see, it looks like your changes closely match the code found in the example at https://github.com/facebook/stylex/tree/main/apps/nextjs-example

Note, not a big deal for me, but I see that your PR has double quotes instead of single quotes, you may want to use meta's convention on this, I'm not sure what it is, but appears to be single quote in the previous version.

nmn commented 1 week ago

Thanks @jherr! Long overdue but finally merged.