search

facebook / stylex

StyleX is the styling system for ambitious user interfaces.
https://stylexjs.com
MIT License
8.22k stars 303 forks source link

fix: 0 value handling for fraction and percentage #520

Closed tounsoo closed 2 months ago

tounsoo commented 2 months ago

What changed / motivation ?

Bug fix 🐛 🔧

Linked PR/Issues

Fixes #498 #478

Additional Context

Added a test in convert-to-className-test.js

Pre-flight checklist

facebook-github-bot commented 2 months ago

Hi @tounsoo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

tounsoo commented 2 months ago

@nmn I also found that the contribution guide could be improved as I wasn't running the prettier ahead of commit.

Potentially changing the fourth point to 4. Ensure it is ready for commit (`npm run precommit`) could improve contributing experience.

If you agree, I can make that small change on this PR or make a new PR for it. LMK 👍