Closed VojGin closed 1 month ago
Hi @VojGin!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Needing cjs
with Rollup was not something I would've expected. Will take a look at this soon.
@VojGin This is exactly what we currently need on our project. @nmn What is blocking this merge request please?
I was away for a couple of weeks. Thanks for the PR! Will put out a release soon.
What changed / motivation ?
I had came to a need of stylex rollup-plugin in the cjs flavor. See this issue for relevant context. https://github.com/facebook/stylex/issues/451
So I added it. My PR is very much inspired by the current implementation in
packages/styles/package.json
Linked PR/Issues
Fixes https://github.com/facebook/stylex/issues/451
Additional Context
The rollup-plugin now generates
lib/*
andlib/es/*
folders. See screenshot:I had run all the tests and lints. But as I'm unfamiliar with the repository. I'd gladly ask for a double check that I didn't break anything vital. 🙏
What I have manually tested:
lib/es/index.mjs
is identical with the oldlib/index.js
Tagging @nmn as a follow-up to our discussion
Pre-flight checklist