support font-stretch percentage values

facebook / stylex

StyleX is the styling system for ambitious user interfaces.

https://stylexjs.com

MIT License

8.21k stars 304 forks source link

support font-stretch percentage values #552

Closed antoinebrault closed 2 months ago

antoinebrault commented 2 months ago

What changed / motivation ?

possible values can be a percentage from 50% to 200% https://developer.mozilla.org/en-US/docs/Web/CSS/font-stretch#values

Pre-flight checklist

[x] I have read the contributing guidelines Contribution Guidelines
[x] Performed a self-review of my code

nmn commented 2 months ago

Thanks!

necolas commented 2 months ago

This PR allows any string, which is not correct. Since flow doesn't support typing this correctly, maybe the compiler should perform the full check

nmn commented 2 months ago

@necolas The ESLint rule and Babel plugin should catch this. Will make sure to update ESLint for now as the Babel validation is a longer term project.