facebook / stylex

StyleX is the styling system for ambitious user interfaces.
https://stylexjs.com
MIT License
8.21k stars 304 forks source link

Fix priority of three physical border properties. #607

Open etlovett opened 1 week ago

etlovett commented 1 week ago

What changed / motivation ?

I was inspecting this file and noticed that these three properties appeared to be stored in the wrong priority set. The other physical longhands (e.g. border-bottom-color and border-left-width) are stored in longHandPhysical.

Linked PR/Issues

None

Additional Context

None

Pre-flight checklist

facebook-github-bot commented 1 week ago

Hi @etlovett!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

etlovett commented 1 week ago

Please accept the CLA so I can merge!

Yep, will do! I'm working to figure out what the right channels are at my employer for this approval.

etlovett commented 1 hour ago

@nmn FYI I have now signed the CLA. Feel free to merge!

facebook-github-bot commented 1 hour ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!