search

facebook / tac_plus

A Tacacs+ Daemon tested on Linux (CentOS) to run AAA via TACACS+ Protocol via IPv4 and IPv6.
MIT License
218 stars 71 forks source link

Add more function prototypes to avoid implicit function declarations #36

Open fweimer-rh opened 1 year ago

fweimer-rh commented 1 year ago

These functions are used in other parts of the codebase. Future compilers may reject implicit function declarations by default; they were removed from C in 1999.

Related to:

facebook-github-bot commented 1 year ago

Hi @fweimer-rh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

elizabethjoshi commented 1 year ago

need a Contributor License Agreement to proceed. Check: https://github.com/facebook/tac_plus/pull/36/checks?check_run_id=10203698271

RollerMatic commented 11 months ago

hey @fweimer-rh , do you mind accepting the CLA ? We can merge this with master, but need the stamp