search

facebook / time

Meta's Time libraries
Apache License 2.0
592 stars 74 forks source link

Serverstats not in line with latest version of Chrony 4.5 #363

Closed mdavids closed 2 months ago

mdavids commented 2 months ago

Chrony 4.5 apperantly returns Reply Type 25, which is missing in:

https://github.com/facebook/time/blob/dfc67bcb9a86816dc6d8a6ce94593925befe147d/ntp/chrony/packet.go#L94

So, perhaps it is time for adding anrpyServerStats4 ?

abulimov commented 2 months ago

Thanks for the report, we'll look into supporting this new reply type soon.

SuperQ commented 2 months ago

I admit I haven't looked at the code, but is there a good way to detect these issues on the client side so we can track packet errors in things like the exporter?

crmdias commented 2 months ago

Thanks again @mdavids for bringing this to our attention! We've addressed the issue with commit 18207c5. I'll go ahead and close this issue now. Your feedback is invaluable - please don't hesitate to report any future issues or suggestions!

SuperQ commented 2 months ago

Thanks! Hmm, it doesn't look like this project uses git tagged releases. I will update the downstream project to the latest git hash.