[chrony] Add support for new serverstats format introduced in chrony 4.4

facebook / time

Meta's Time libraries

Apache License 2.0

592 stars 74 forks source link

[chrony] Add support for new serverstats format introduced in chrony 4.4 #367

Closed raphaelthomas closed 2 months ago

raphaelthomas commented 2 months ago

Adds support for the new serverstats format RPY_SERVER_STATS4 introduced in commits 0845df76 and 5508b01b in the chrony repository and included in chrony release 4.4:

New in version 4.4
==================
...
* Add timestamp sources to serverstats report and make its fields 64-bit
...

Resolves #363.

crmdias commented 2 months ago

Hi @raphaelthomas, thanks for the PR! Would you like to undraft it for review or need any support? We are looking into addressing the underlying issue soon.

crmdias commented 2 months ago

Thanks again @raphaelthomas for the PR! We have merged these changes with commit 18207c5. Looking forward to your future contributions!

Frankkkkk commented 2 months ago

Arf, I just saw the "typo":

    NTPKernelTxtimestamps uint64

    NTPHwRxTimestamps     uint64

timestamp ≠ Timestamp... Well, too late now

crmdias commented 2 months ago

Thanks for pointing this out @Frankkkkk ! Could you please review the commit that was pushed? I believe the change addressed this. This PR was closed without merging, as my commit was generated by internal automation with no accompanying PR.