search

facebook / time

Meta's Time libraries
Apache License 2.0
592 stars 74 forks source link

use netip.Addr in sptp to reduce heap allocations #370

Closed abulimov closed 2 months ago

abulimov commented 2 months ago

Summary: new cool netip package provides better version of IP type, which is fixed length, can be passed by value, is comparable and thus can be used as map keys. We save plenty of allocations by not converting IPs to strings to use as map keys.

Reviewed By: leoleovich, deathowl

Differential Revision: D58733846

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D58733846

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D58733846

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D58733846

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/time@81310981f32719f067d8ed4f51afea5450a0c177.