search

facebook / time

Meta's Time libraries
Apache License 2.0
592 stars 74 forks source link

Add static lib target #374

Closed deepshah133 closed 2 months ago

deepshah133 commented 2 months ago

Summary: Previous changes to conda build caused build breakages due to fbclock.so not being copied correctly. One of the suggestions was to make it static lib that further links to libnccl. So that all the upper layers only have to worry about managing libnccl.so, as they already do and not concern with managing other dependent libs.

In this take2, introduce static lib target for fbclock, that will be further be linked to libnccl.so in subsequent changes.

Differential Revision: D58930591

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D58930591

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/time@b656f6accbd919e173407cc62d3d46b5f08a35b4.