Closed daxpedda closed 1 year ago
There also was a change in the test in the test vectors between draft-16 and draft-17:
The tests didn't change, just the output, because of the change to the context string. For a moment I was thinking: how the hell did CI pass if I forgot to update the test vectors :smile:.
This is now ready to be merged, but if possible I would like to get a new pre-release for voprf
in beforehand.
Now builds on top of https://github.com/facebook/voprf/pull/102.
This is ready to be merged now!
This updates VOPRF to be in sync with draft 19.
There are no changes compared to draft 11, which is what we were on until now, except:
OPRFV1-
.The change to the Ciphersuite ID requires us to update to
elliptic-curve
v0.13.0-pre.5, which I've done here. This also requires an upgrade to Rust 1.61.This small change posed some difficulties because of the non-fixed-size nature of this ID. To avoid allocation I had to change the API in
elliptic-curve
(https://github.com/RustCrypto/traits/pull/1238) and introduce a new internal helper type:Dst
.This also changed some of hash traits we used, namely instead of
Digest
we no requireDefault + FixedOutput + HashMarker
, which should pose no downstream issues.This build on top of:
elliptic-curve
: https://github.com/RustCrypto/traits/pull/1238p256
(for testing only): https://github.com/RustCrypto/elliptic-curves/pull/732We should probably wait for the release ofWas released!elliptic-curve
v0.13.0-pre.4 before merging this.Builds on top of https://github.com/facebook/voprf/pull/102.