search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.05k stars 537 forks source link

Wangle doesn't compile with fresh folly #10

Closed vadimkantorov closed 8 years ago

vadimkantorov commented 8 years ago

Hi,

It seems the operator-> (https://github.com/facebook/folly/blob/e845ef57f1f368944123e4a50bd4d1616a363efa/folly/Singleton.h#L453) was removed at some point, so wangle compiles no more.

By fresh folly I mean commit 8f1e662a59dec3476bf626b283effaa8a88acdd5 (and Singleton.h https://github.com/facebook/folly/blob/8f1e662a59dec3476bf626b283effaa8a88acdd5/folly/Singleton.h).

Vadim

vadimkantorov commented 8 years ago

I could fix the compilation by replacing "->" to ".get()->" on line 62 of wangle/concurrent/GlobalExecutor.cpp

djwatson commented 8 years ago

Wangle was pushed, should be fixed?