search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.04k stars 536 forks source link

Check existence of optional libraries before linking #100

Closed lizhanhui closed 6 years ago

lizhanhui commented 7 years ago

We need to check result of find_package before linking against them. For example, librt is NOT available in Mac and current CMakeLists.txt would cause compilation failure.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

yfeldblum commented 6 years ago

It looks like there are conflicts with master. Please rebase this PR?