search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.04k stars 536 forks source link

`CALLBACK` is a macro for `__stdcall` or `__cdecl` on Windows. #116

Closed capsocrates closed 6 years ago

capsocrates commented 6 years ago

https://github.com/facebook/wangle/blob/095f6bbf071c38ad4f9ad65556910ee31dece811/wangle/acceptor/EvbHandshakeHelper.h#L66

This line does not compile on Windows, as a calling convention is not a valid enum member, and the compiler replaces CALLBACK with either __stdcall or __cdecl.

yfeldblum commented 6 years ago

Fixed in 5c4935af43cce64487458e10dc7ebd609ad7692b.