search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.05k stars 537 forks source link

Fix: Compile time error in ConnectionManager::makeUnique #12

Closed mtanski closed 8 years ago

mtanski commented 8 years ago

ConnectionManager::makeUnique was calling folly::make_unique with an extra template argument (destructor). It looks like the folly code use to accept this in the past. Now folly updated it to be more C++14 standard compliant and it no longer accepts second template argument.

http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique

mtanski commented 8 years ago

And just to be sure, I signed the CLA

mtanski commented 8 years ago

This has been fixed by a push from upstream.