search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.05k stars 537 forks source link

Fix #17 #19

Closed guoxiao closed 8 years ago

guoxiao commented 8 years ago
viswanathgs commented 8 years ago

Do you mind signing CLA so that I call pull your commit in? https://code.facebook.com/cla.

guoxiao commented 8 years ago

@viswanathgs I've already signed the CLA.

viswanathgs commented 8 years ago

Thanks, I merged this.

guoxiao commented 8 years ago

I find that on my new Fedora 23 (gcc 5.3.1) the commit https://github.com/facebook/wangle/commit/b1009e9670573d5cbb102303f149f8528f1881fb is not needed, which will break the build with a error /usr/bin/ld: cannot find /usr/lib64/libatomic.so.1.1.0.

Maybe some checks should be added to CMakeList.txt to deal with different compilers.

viswanathgs commented 8 years ago

We officially only support Ubuntu 14.04 for now, though it'll be awesome if you could get it fully working on Fedora 23!