facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.05k stars 537 forks source link

compile error #2

Closed helloleef closed 8 years ago

helloleef commented 9 years ago

[ 4%] Building CXX object CMakeFiles/wangle.dir/codec/LengthFieldPrepender.cpp.o In file included from /usr/local/include/folly/futures/Promise-inl.h:23:0, from /usr/local/include/folly/futures/Promise.h:115, from /usr/local/include/folly/futures/Future.h:30, from /home/leef/download/wangle/wangle/../wangle/channel/Handler.h:13, from /home/leef/download/wangle/wangle/../wangle/codec/ByteToMessageCodec.h:13, from /home/leef/download/wangle/wangle/../wangle/codec/LengthFieldPrepender.h:13, from /home/leef/download/wangle/wangle/codec/LengthFieldPrepender.cpp:11: /usr/local/include/folly/futures/detail/Core.h: In instantiation of ‘class folly::detail::Core’: /usr/local/include/folly/futures/Future-inl.h:64:5: required from ‘void folly::Future::detach() [with T = void]’ /usr/local/include/folly/futures/Future-inl.h:58:10: required from ‘folly::Future::~Future() [with T = void]’ /home/leef/download/wangle/wangle/codec/LengthFieldPrepender.cpp:90:39: required from here /usr/local/include/folly/futures/detail/Core.h:77:3: error: static assertion failed: void futures are not supported. Use Unit instead. static_assert(!std::is_void::value, ^ make[2]: * [CMakeFiles/wangle.dir/codec/LengthFieldPrepender.cpp.o] Error 1 make[1]: * [CMakeFiles/wangle.dir/all] Error 2 make: *\ [all] Error 2

bmatheny commented 9 years ago

cc @jsedgwick

viswanathgs commented 9 years ago

This is because of the void to folly::Unit refactor that got pushed to https://github.com/facebook/folly, which breaks Wangle. This should be fixed when Wangle gets pushed next.

bmatheny commented 9 years ago

@helloleef looking good?