search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.04k stars 535 forks source link

set IMPORTED_LINK_INTERFACE_LIBRARIES to ${LIBGFLAGS_LIBRARY} for glog::glog (#272) #208

Closed Atry closed 1 year ago

Atry commented 1 year ago

Summary: X-link: https://github.com/facebookincubator/mvfst/pull/272

X-link: https://github.com/facebook/fboss/pull/118

X-link: https://github.com/facebookincubator/fizz/pull/81

X-link: https://github.com/facebookexperimental/eden/pull/127

X-link: https://github.com/facebook/sapling-staging/pull/7

X-link: https://github.com/facebookexperimental/edencommon/pull/4

X-link: https://github.com/facebookexperimental/rust-shed/pull/34

X-link: https://github.com/facebook/fbthrift/pull/521

X-link: https://github.com/facebook/watchman/pull/1055

X-link: https://github.com/facebook/folly/pull/1854

X-link: https://github.com/facebook/openr/pull/140

X-link: https://github.com/facebook/fb303/pull/31

Previously Folly provided a polyfill of the GflagsFlagSaver symbol, which was removed since https://github.com/facebook/folly/commit/4dadde1256f74e756510a499c86459967f78afb9. Therefore, the glog should solve the GflagsFlagSaver symbol from gflags.

This diff added gflags libraries as a dependency of the CMake project glog::glog into fbcode_builder's FindGlog.cmake, so that the fbcode_builder users will be able to automatically link with gflags.

Differential Revision: D39220438

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D39220438