facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.05k stars 539 forks source link

Paramatized rust_static_library to enable CXX support #221

Closed jdelliot closed 11 months ago

jdelliot commented 11 months ago

Summary: X-link: https://github.com/facebook/openr/pull/150

X-link: https://github.com/facebook/hhvm/pull/9403

X-link: https://github.com/facebook/folly/pull/2092

X-link: https://github.com/facebook/fb303/pull/42

X-link: https://github.com/facebookincubator/velox/pull/7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, USE_CXX_INCLUDE, to the CMake function, rust_static_library, to enable adding the cxxbridge path to the include path.

Differential Revision: D50772544

facebook-github-bot commented 11 months ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 11 months ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 11 months ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 11 months ago

This pull request has been merged in facebook/wangle@f3140335f561e759038ef0e9c16d2e41ee192138.