facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.

Apache License 2.0

3.04k stars 536 forks source link

Changes for OS X support #47

Closed Dalzhim closed 8 years ago

Dalzhim commented 8 years ago

I have made a few changes in order to get Wangle to build on OS X. There were 4 different problems which I've fixed in 4 different commits. The commit messages should be self-explanatory. The c++14 requirement might not be the best option to solve the compilation issue depending on the project's objective. Maybe the methods that relied on return type deduction should just specify their return type explicitly so as to remain c++11 compatible. I leave that to discussion.

elliottneilclark commented 8 years ago

40 got merged which added the openssl headers path. Can you update the pull request?

Dalzhim commented 8 years ago

The PR has been updated.

elliottneilclark commented 8 years ago

@facebook-github-bot import

ghost commented 8 years ago

Thanks for importing. If you are an FB employee go to Phabricator to review.

elliottneilclark commented 8 years ago

@facebook-github-bot shipit

elliottneilclark commented 8 years ago

Thanks for the PR. The latest build and looks good to me.

ghost commented 8 years ago

Thanks for importing. If you are an FB employee go to Phabricator to review.