search

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.
Apache License 2.0
3.04k stars 536 forks source link

wangle/ssl/PasswordInFile override Error #63

Closed veejai closed 7 years ago

veejai commented 7 years ago

Any Ideas how to fix this?

[ 56%] Building CXX object CMakeFiles/wangle.dir/deprecated/rx/Dummy.cpp.o [ 58%] Building CXX object CMakeFiles/wangle.dir/ssl/PasswordInFile.cpp.o In file included from /tmp/fblualib-build.Nkyraj/wangle/wangle/ssl/PasswordInFile.cpp:10:0: /tmp/fblualib-build.Nkyraj/wangle/wangle/../wangle/ssl/PasswordInFile.h:21:8: error: ‘void wangle::PasswordInFile::getPassword(std::string&, int)’ marked override, but does not override void getPassword(std::string& password, int size) override { ^ make[2]: * [CMakeFiles/wangle.dir/ssl/PasswordInFile.cpp.o] Error 1 make[1]: * [CMakeFiles/wangle.dir/all] Error 2 make: *\ [all] Error 2

anirudhvr commented 7 years ago

There was a change in folly which has the Base class of PasswordInFile to mark the method const. I think the related wangle change will sync shortly, else please confirm that the method signature in the base class (folly/io/async/SSLContext.h) matches.

https://github.com/facebook/folly/commit/0c723a6045a185e4cae76ca42520e1274648be3c