Allow FutureExecutor::addFuture() to forward arguments to embedded Executor

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.

Apache License 2.0

3.04k stars 536 forks source link

Allow FutureExecutor::addFuture() to forward arguments to embedded Executor #66

Closed sanjosh closed 2 years ago

sanjosh commented 7 years ago

Currently, FutureExecutor::addFuture() does not accept arguments like priority and expirationTime which can be passed to the embedded folly::Executor.

Added std::forward() support for variable number of arguments

Added two tests for CPUExecutor and IOExecutor to verify changes see test CPUFuturePoolWithParameters and IOFuturePoolWithParameters

facebook-github-bot commented 7 years ago

@djwatson has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Orvid commented 2 years ago

executors moved into Folly a few years back, so if this is still needed, it would need to be reopened against the folly repo.