Support older versions of OpenSSL

facebook / wangle

Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.

Apache License 2.0

3.04k stars 536 forks source link

Support older versions of OpenSSL #88

Closed msteinert closed 7 years ago

msteinert commented 7 years ago

Use getSelectedNextProtocolNoThrow instead of getSelectedNextProtocol so that the handshake can complete with older versions of OpenSSL that do not support protocol negotiation.

facebook-github-bot commented 7 years ago

@anirudhvr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

anirudhvr commented 7 years ago

This looks fine, though you may not want a stronger check if your application depends on ALPN/NPN support or codec selection, or want to warn when using OpenSSL without NPN/ALPN support.