pywatchman: Print stderr if there was an error

facebook / watchman

Watches files and records, or triggers actions, when they change.

https://facebook.github.io/watchman/

MIT License

12.57k stars 987 forks source link

pywatchman: Print stderr if there was an error #1004

Closed jez closed 1 year ago

jez commented 2 years ago

I was running watchman-make at the command line and getting a backtrace that said "command failed."

It turns out that somehow my terminal process had a nice value of 5, and was failing the check that watchman has for nice_value > min_acceptable_nice_value, but I couldn't see that message because it was getting swallowed.

Seems that if we know we're about to make the process crash by raising an exception, we may as well dump a little extra debugging information on our way out.

jez commented 1 year ago

I still would appreciate the contents of this change merged but I want a small list of open pull requests more, so I'm closing this. Feel free to re-open if you'd like to action it.