search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 987 forks source link

Fixed support to ukraine sticking to screen #1020

Closed h3cksamrat closed 2 years ago

facebook-github-bot commented 2 years ago

Hi @h3cksamrat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

chadaustin commented 2 years ago

@h3cksamrat Thanks for the report and the patch. Can you explain the symptom you're seeing? I'm unable to reproduce -- maybe.

dmitryvinn-fb commented 2 years ago

@h3cksamrat Thank you making this PR! Can you please post screenshots of how the header+banner look initially and when you scroll?

h3cksamrat commented 2 years ago

First, the banner looked like this Support Banner

After Scrolling, the website looks like afterScrolling

After applying this fix fixedScrolling

h3cksamrat commented 2 years ago

@dmitryvinn-fb I have included screenshots

facebook-github-bot commented 2 years ago

@dmitryvinn-fb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.