search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

Fix synthesize arg in pywatchman.client.capabilityCheck #1034

Closed herg closed 2 years ago

herg commented 2 years ago

pywatchman.capabilities.synthesize expects an opts dict of the shape {"required": list[str], "optional": list[str]}.

pywatchman.client.capabilityCheck is incorrectly passing an optional list[str] as the opts arg,

orf commented 2 years ago

@chadaustin this is currently breaking all Django usages of watchman (https://github.com/django/django/blob/main/django/utils/autoreload.py#L628) - is it possible to get this tiny fix looked at?

facebook-github-bot commented 2 years ago

@chadaustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

orf commented 2 years ago

Thank you!

SebCorbin commented 1 year ago

Could we have a release of pywatchman to get this fix live?