search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

watchman: docs: document Git SCM support #1036

Closed sluongng closed 2 years ago

sluongng commented 2 years ago

Git SCM support has been added since 2021.08.30 release via a pull request by @arxanas. (1)

Update website documentation to reflect that Git support has been added additionally to Mercurial.

(1): https://github.com/facebook/watchman/pull/934

facebook-github-bot commented 2 years ago

Hi @sluongng!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

sluongng commented 2 years ago

cc: @wez 🙏

arxanas commented 2 years ago

FYI the Git support is buggy ☹️. IIRC, there's some command in the API that needs to get the changes since a given commit, but my implementation only gets the committed changes, not the uncommitted changes.

sluongng commented 2 years ago

FYI the Git support is buggy ☹️. IIRC, there's some command in the API that needs to get the changes since a given commit, but my implementation only gets the committed changes, not the uncommitted changes.

Getting the doc out should help us increase the contribution toward this?

Do you want to open a separate issue for tracking the bug?

facebook-github-bot commented 2 years ago

@chadaustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

sluongng commented 2 years ago

Not sure why but this was not reflected in https://facebook.github.io/watchman/docs/scm-query.html

@chadaustin do you have any idea?

chadaustin commented 2 years ago

Ah, I forgot to deploy the website. Should be out now. :)