Closed Atry closed 5 months ago
This pull request was exported from Phabricator. Differential Revision: D39340650
Hi @Atry!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
This pull request has been merged in facebook/watchman@3d74a3ae8919cdd84d2bc806e0a84e7ea7ab5e7d.
Summary: X-link: https://github.com/facebookincubator/fizz/pull/82
X-link: https://github.com/facebookincubator/velox/pull/2487
X-link: https://github.com/facebookincubator/hsthrift/pull/101
X-link: https://github.com/facebookincubator/katran/pull/172
X-link: https://github.com/facebookincubator/mvfst/pull/273
X-link: https://github.com/fairinternal/AIRStore/pull/38
LibUnwind
is a dependency ofglog
according to objdump. This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported libraryglog::glog
as an element in theIMPORTED_LINK_INTERFACE_LIBRARIES
property.Without this diff, there will be a linker error like this:
Differential Revision: D39340650