search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

Linux PopOS! 22.04 [Ubuntu based] - Rust and Cargo dependency #1061

Closed gsdiniz closed 1 year ago

gsdiniz commented 1 year ago

I am trying to build watchman using autogen.sh file in PopOS! 22.04.

But the process always fails in the build of watchman and watchmanctl because Cargo is not installed.

After I installed them using this => https://rustup.rs/ the build of watchman finally worked.

This dependency in not listed or informed in any docs.

chadaustin commented 1 year ago

Ah, good point. I just reproduced this experience and it's pretty confusing indeed. Ninja fails with an error and it's hard to tell exactly why.

I'll change the CMake build to fail early if cargo cannot be found.

In terms of documentation - is there a particular place you wish this had been written down?

gsdiniz commented 1 year ago

In the Building from Source section or be installed automatic by install-system-packages.sh file.

set -x python3 "$(dirname "$0")/build/fbcode_builder/getdeps.py" install-system-deps --recursive watchman

chadaustin commented 1 year ago

OK, I'll update the installation page to mention that too. We probably don't want to automatically install cargo, since there isn't one obvious installation source. Some people prefer it from the OS package manager, and some from https://rustup.rs

Thanks! This should close automatically when the fix lands.

VictorHugoBN commented 7 months ago

In the Building from Source section or be installed automatic by install-system-packages.sh file.

set -x python3 "$(dirname "$0")/build/fbcode_builder/getdeps.py" install-system-deps --recursive watchman

This worked for me, thanks!