search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

Fix formatters for `w_string` and `w_string_piece` #1064

Closed carlocab closed 1 year ago

carlocab commented 1 year ago

This is needed for fmt 9+. [1]

This fixes a build failure seen while building Watchman 2022.10.10 for Homebrew at Homebrew/homebrew-core#112788 (against fmt 9.1.0). Without this, the build fails with

  /opt/homebrew/include/fmt/format.h:3973:30: error: no matching member function for call to 'format'
    out = value_formatter_.format(map(*it), ctx);
          ~~~~~~~~~~~~~~~~~^~~~~~

Full build logs available [2]. Errors for the arm64 Monterey runner start at [3].

[1] https://fmt.dev/9.0.0/api.html#formatting-user-defined-types [2] https://github.com/Homebrew/homebrew-core/actions/runs/3220853975 [3] https://github.com/Homebrew/homebrew-core/actions/runs/3220853975/jobs/5276286644#step:6:704

facebook-github-bot commented 1 year ago

@xavierd has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.