search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

GitHub Workflows security hardening #1071

Closed sashashura closed 10 months ago

sashashura commented 1 year ago

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura commented 1 year ago

@chadaustin could you please review?

sashashura commented 1 year ago

An example of a recent workflow run with unrestricted permissions: image

facebook-github-bot commented 11 months ago

@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 10 months ago

@genevievehelsel merged this pull request in facebook/watchman@5be84abb85f29076f7f21e83393e2ce6c6691d23.