search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.57k stars 986 forks source link

CMakeLists.txt: Fix build with CMake 3.25.0 #1076

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

A change in CMake 3.25.0 makes CHECK_INCLUDE_FILES refuse a second argument that contains slashes, because it will eventually be passed to try_compile as a SOURCE_FROM_VAR argument, which cannot contain path components ^1:

CMake Error at /opt/homebrew/Cellar/cmake/3.25.0/share/cmake/Modules/CheckIncludeFiles.cmake:136 (try_compile):
  SOURCE_FROM_VAR given invalid filename "have_CoreServices/CoreServices.h.c"
Call Stack (most recent call first):
  CMakeLists.txt:240 (CHECK_INCLUDE_FILES)

While this has already been reported to CMake ^2, this patch is still necessary to fix build with the already-released version.

facebook-github-bot commented 1 year ago

Hi @ZhongRuoyu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

@xavierd has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.