facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.44k stars 990 forks source link

🐛 Fix flaky test_sinceRelativeRoot #1103

Closed marianosimone closed 1 year ago

marianosimone commented 1 year ago

Adjust the clock before querying, as mkdir and touch sometimes are so fast that make the query have the same time as clock, and not see the changes.

Fixes #1100

facebook-github-bot commented 1 year ago

Hi @marianosimone!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

fanzeyi commented 1 year ago

Thanks! This looks reasonable. I'll get it merge tomorrow at work.

We really should have a fake test clock mechanism in Watchman.

facebook-github-bot commented 1 year ago

@fanzeyi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@fanzeyi merged this pull request in facebook/watchman@3d7d6908090c41a22f43df2b6c7874c46b34f6fb.