`test_clock_sync` seems flaky - Githubissues

facebook / watchman

Watches files and records, or triggers actions, when they change.

https://facebook.github.io/watchman/

MIT License

12.65k stars 992 forks source link

`test_clock_sync` seems flaky #1104

Open marianosimone opened 1 year ago

marianosimone commented 1 year ago

This is similar to [watchman/issues/1100] test_sinceRelativeRoot seems flaky

I'm trying to build from source, and I keep getting flaky results on https://github.com/facebook/watchman/blob/6b0361c3464efcb5b7db11937f0bd9f84c865914/watchman/integration/test_clock.py#L29

While debugging, I added some log lines, and it immediately stopped flaking (Heisenbug flag!)

I haven't fully looked into the implementation to understand this 100%, but could it be that:

https://github.com/facebook/watchman/blob/6b0361c3464efcb5b7db11937f0bd9f84c865914/watchman/integration/test_clock.py#L21-L27

can flake if not enough time passes between the assignment to clock1 and the clock2?