search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.42k stars 989 forks source link

Ubuntu packags missing since May #1150

Closed andrewnicols closed 11 months ago

andrewnicols commented 12 months ago

All releases since May are missing Ubuntu packages.

See an example of the failing build here: https://github.com/facebook/watchman/actions/runs/5505064162/jobs/10032023257

xendarboh commented 11 months ago

The failing build logs indicate sudo package is missing. Looks like it could be fixed by adding sudo to this line:

https://github.com/facebook/watchman/blob/main/watchman/build/package/ubuntu-env/Dockerfile#L10

chadaustin commented 11 months ago

I've been meaning to look at this and haven't had a chance. @xendarboh I think you're on the right track. Want to put up a PR with that fix? We should be able to tell from the PR itself whether the GitHub Actions succeed.

xendarboh commented 11 months ago

@chadaustin PR submitted.