search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.79k stars 996 forks source link

feat: add rust client apis for trigger, trigger-list, trigger-del #1221

Closed fowles closed 5 months ago

facebook-github-bot commented 5 months ago

Hi @fowles!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 5 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 5 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

fowles commented 5 months ago

I added trigger-list as well. I decided to punt on deserialize the more complicated portions of the request.

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

fowles commented 5 months ago

friendly ping, I would love to get this in so I can use it in https://github.com/martinvonz/jj/issues/3855

fowles commented 5 months ago

@MichaelCuevas gentle ping

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

quark-zju commented 5 months ago

Somehow the internal CI performs clippy checks, which this PR did not pass. Could you try to rebase past https://github.com/facebook/watchman/commit/861531ff9c6318324c64f2bf5a1dae266280e106 to address the clippy issues?

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

fowles commented 5 months ago

Somehow the internal CI performs clippy checks, which this PR did not pass. Could you try to rebase past 861531f to address the clippy issues?

Done!

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@quark-zju has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@quark-zju merged this pull request in facebook/watchman@b4f8c8d3a7f0e4cf73cd7efd38791aa19c62b3be.