search

facebook / watchman

Watches files and records, or triggers actions, when they change.
https://facebook.github.io/watchman/
MIT License
12.4k stars 987 forks source link

chore: upgrade from structopt to clap #1224

Closed fowles closed 2 weeks ago

fowles commented 3 weeks ago

structopt is in maintence mode and explicitly refers to clap as the successor. Modernize examples a bit and switch names to match the clap examples.

facebook-github-bot commented 3 weeks ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 weeks ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

zzl0 commented 2 weeks ago

Looks good, thanks for the PR.

Our internal Buck build is failing due to the new clap, I will update it internally and merge the PR.

@genevievehelsel is working on it, thanks

fowles commented 2 weeks ago

Just an FYI that this and https://github.com/facebook/watchman/pull/1221 are in mild conflict. I am happy to update either one after the first one lands

facebook-github-bot commented 2 weeks ago

@fowles has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 weeks ago

@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

genevievehelsel commented 2 weeks ago

I'll try to land this one first, fixed some internal lints on it and omitted the gitignore from it since you change it in https://github.com/facebook/watchman/pull/1221 :)

fowles commented 2 weeks ago

Sounds good. I have rebased https://github.com/facebook/watchman/pull/1221 onto this one and fixed examples to use clap.

facebook-github-bot commented 2 weeks ago

@genevievehelsel merged this pull request in facebook/watchman@63b2384a0da6c336e7ec242e72900406de67d8a9.