Fix inconsistent openssl dependency in cmake manifest

facebook / watchman

Watches files and records, or triggers actions, when they change.

https://facebook.github.io/watchman/

MIT License

12.57k stars 987 forks source link

Fix inconsistent openssl dependency in cmake manifest #991

Closed alchen closed 11 months ago

alchen commented 2 years ago

Fixes https://github.com/facebook/watchman/issues/990

All manifests, except cmake, specifies [dependencies.not(os=linux)] for openssl. The newly added dependency otherwise causes a "project openssl has no builder" error when building on Linux distros.

chadaustin commented 2 years ago

Thanks. I think this was also fixed by https://github.com/facebook/watchman/commit/7c31dfdb1c8c44d261447e9b03b79492c025a9e3, but I'll cc @ahornby

alchen commented 2 years ago

@chadaustin Yes, removing the dependency altogether is as good as fixing it for Linux. Feel free to close this as needed.

genevievehelsel commented 11 months ago

closing per comments