search

facebook / wdt

Warp speed Data Transfer (WDT) is an embeddedable library (and command line tool) aiming to transfer data between 2 systems as fast as possible over multiple TCP paths.
https://www.facebook.com/WdtOpenSource
Other
2.86k stars 391 forks source link

1048576 bytes converted to megabytes #136

Closed jluo117 closed 7 years ago

jluo117 commented 7 years ago

added a conversion to make it easy for one to determine the size of WDT

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

ldemailly commented 7 years ago

Thanks for your interest in WDT, but 1048576 bytes is exactly a traditional 'megabyte' (MiB), not "a little over"

also if you make edits please make sure to keep the max line width at 80 columns

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ldemailly commented 7 years ago

going to close this now - but if you feel we can reword so it's more clear, please submit a new diff