search

facebook / winterfell

A STARK prover and verifier for arbitrary computations
MIT License
795 stars 180 forks source link

Update constraint degree checks #305

Closed Al-Kindi-0 closed 2 months ago

Al-Kindi-0 commented 2 months ago

This PR relaxes the constraint degree checks so that they become degree bounds checks instead of degree equality checks.

Al-Kindi-0 commented 2 months ago

I have removed now constraint degree from the code base. I personally don't like the result as it is not straightforward to know if the max degree of the (constraints of the) AIR is chosen correctly. Moreover, even in debug mode, I am not sure we can efficiently test this and hence the only way to know that this is the case is to wait for verification to not pass. Thus I am not in favor of removing the constraint degrees unless we solve the above.

Note also that this not polished in some places.

Al-Kindi-0 commented 2 months ago

Closing this in favor of #311 since it seems that having degree constraints is better than not having them.