facebook / winterfell

A STARK prover and verifier for arbitrary computations
MIT License
773 stars 176 forks source link

Move s-column constraint evaluation logic into the regular constraint evaluator #306

Closed Al-Kindi-0 closed 1 week ago

Al-Kindi-0 commented 3 weeks ago

Currently during constraint evaluation and when LogUp-GKR is enabled, we are reading both main and aux frames twice from the trace LDE: the first time during regular constraint evaluation and the second time during S-column constraint evaluation.

An alternative approach could be to move S column evaluation logic into the regular constraint evaluator.

_Originally posted by @irakliyk in https://github.com/facebook/winterfell/pull/297#discussion_r1740408424_

Al-Kindi-0 commented 1 week ago

Done as part of #317