facebook / winterfell

A STARK prover and verifier for arbitrary computations
MIT License
795 stars 180 forks source link

ReadAdapter is broken #308

Closed bitwalker closed 2 months ago

bitwalker commented 2 months ago

It appears that the implementation of ReadAdapter, at least when applied to a File, is broken. I haven't yet looked to pin down the specific problem, but it appears to me that we may have an off-by-one error of some kind, as we get a panic attempting to read beyond the end of a buffer by 1 byte (at least in the case I have where this comes up).

I'll try to take a look at this tomorrow, but wanted to at least get this bug on our radar, as it currently affects various bits of Miden functionality that builds on winter-utils.